Ticket #101 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

Repository.delete() should throw RecordNotFoundException

Reported by: bruno Owned by: evert
Priority: major Milestone: 0.2
Component: Repository Version:
Keywords: Cc: lily-developers@…

Description

Repository.delete() should throw a RecordNotFoundException? instead of silently skipping a non-existent record.

Change History

comment:1 Changed 3 years ago by bruno

  • Milestone set to 0.2

comment:2 Changed 3 years ago by bruno

  • Status changed from new to closed
  • Resolution set to fixed

(In [4216]) Json interface (#60): adding more resources and more functionality to the existing resources. Added an ExceptionMapper? to format the error responses. All resources (URIs + methods on them) should now be present, but many of them still completely untested.

Some changes/fixes to the repository code:

  • Repository.delete(): throw RecordNotFoundException?, previously delete silently skipped a non-existing record. Fixes #101.
  • Repository.create(): removed unused but declared throws of RecordNotFoundException?, this exception makes no sense for record creation.
  • Repository.getRow: the test to check if a record exists did not make sense, now it checks for the presence of the record type column. Fixes #102.
Note: See TracTickets for help on using tickets.