Changeset 1913

Timestamp:

2011-07-20 14:58:20 (10 months ago)

Author:

jgou

Message:

clone values and labels from options before setting them to avoid that - in case the control is nullable - multiple null options are prepended when the set function is called more than once ; this fixes #464

File:

• trunk/modules/kauri-forms/kauri-forms-framework/src/main/kauri/static-{build}.key/kauri.forms/field.js (modified) (3 diffs)

trunk/modules/kauri-forms/kauri-forms-framework/src/main/kauri/static-{build}.key/kauri.forms/field.js

@@ -159 +159 @@
     */
     Options.prototype.set = function( values, labels) {
-        
-        this.values = values;
+        values = $.extend([], values); //clone to avoid issue #464
+        labels = labels ? $.extend([], labels) : null; 
         if (this.type) {
             this.userValues = new Array();
@@ -180 +180 @@
             for (var i = values.length; i>0; i--) {
                 values[i] = values[i-1];
-                labels[i] = labels[i-1];
+                labels[i] = labels[i-1]; 
                 this.userValues[i] = this.userValues[i-1];
             }
@@ -188 +188 @@
         }
 
-        this.labels = labels;
-        
+        this.values = values;
+        this.labels = labels;        
         
         this.update();