Changeset 1717

Timestamp:

2010-09-30 12:49:43 (3 years ago)

Author:

mpo

Message:

fixes #368
Tracking the last issues request for refresh-options avoids updating the options with results that came in too late.
(this should allow for better responsiveness then the async: false approach suggested in the issue)

File:

• trunk/modules/kauri-forms/kauri-forms-framework/src/main/kauri/static-{build}.key/kauri.forms/field.js (modified) (2 diffs)

trunk/modules/kauri-forms/kauri-forms-framework/src/main/kauri/static-{build}.key/kauri.forms/field.js

@@ -203 +203 @@
             var uri = this.uri.expand(this.uriContext);
             var me = this;
-            var callback = function( data) {
-    
-                me.parseOptions(data);
+            var onSuccess = function( data, status, xhr) {
+                if (xhr && me.lastXhr == xhr) { //ignore responses that are not linked to the last request 
+                    me.parseOptions(data);
+                    me.lastXhr = null;
+                }
             };
-            var errorcallback = function( data) {
-                
-                me.clearOptions(data);
+            var onError = function( xhr, status, err) {
+                if (xhr && me.lastXhr == xhr) { 
+                    me.clearOptions();
+                    me.lastXhr = null;
+                }
             };
 
-            $.ajax( {
+            // assign lastXhr to make sure only the return of this last one is accepted 
+            this.lastXhr = $.ajax( {
                 // take async setting from setup
-                type :"GET",
-                url :uri,
-                processData :false,
-                dataType :"json",
-                success :callback,
-                error :errorcallback,
-                beforeSend: function(xhr) {
-                // setting datatype to json should be enough, unfortunately
-                // the restlet content negotiation chokes on the resulting
-                // accept header: application/json, text/javascript, */*
-                // and doesn't prefer the json variant.
-                // see issue #95
-                xhr.setRequestHeader("Accept", "application/json");
+                type       : "GET",
+                url        : uri,
+                processData: false,
+                dataType   : "json",
+                success    : onSuccess,
+                error      : onError,
+                beforeSend : function(xhr) {
+                    // setting datatype to json should be enough, unfortunately
+                    // the restlet content negotiation chokes on the resulting
+                    // accept header: application/json, text/javascript, */*
+                    // and doesn't prefer the json variant.
+                    // see issue #95
+                    xhr.setRequestHeader("Accept", "application/json");
                 }
             });
@@ -304 +309 @@
       * @param {Array} data
       */
-     Options.prototype.clearOptions = function( data) {
+     Options.prototype.clearOptions = function( ) {
 
          this.set([], []);