Changeset 1716

Timestamp:

2010-09-29 09:11:26 (3 years ago)

Author:

bruno

Message:

Adding log4j MBean registration. This allows to e.g. modify log levels on the fly via jconsole.
The code is copied from Apache ZooKeeper? but it is a pretty common snippet found in many places.
Required upgrade to log4j 1.2.16 to avoid errors about the same mbean being registered multiple times.

Location:

trunk

Files:

• core/kauri-runtime-cli/src/main/java/org/kauriproject/runtime/cli/KauriRuntimeCli.java (modified) (2 diffs)
• core/kauri-runtime-cli/src/main/java/org/kauriproject/runtime/cli/Logging.java (modified) (2 diffs)
• pom.xml (modified) (1 diff)

trunk/core/kauri-runtime-cli/src/main/java/org/kauriproject/runtime/cli/KauriRuntimeCli.java

@@ -24 +24 @@
 import java.util.logging.LogManager;
 
+import javax.management.JMException;
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
@@ -183 +184 @@
                 cmd.getOptionValue(consoleLoggingOption.getOpt()), cmd.getOptionValue(consoleLogCatOption.getOpt()));
 
+        try {
+            Logging.registerLog4jMBeans();
+        } catch (JMException e) {
+            infolog.error("Unable to register log4j JMX control", e);
+        }
+
         infolog.info("Starting the Kauri Runtime.");
         

trunk/core/kauri-runtime-cli/src/main/java/org/kauriproject/runtime/cli/Logging.java

@@ -17 +17 @@
 
 import org.apache.log4j.*;
+import org.apache.log4j.jmx.HierarchyDynamicMBean;
+import org.apache.log4j.spi.LoggerRepository;
 import org.apache.log4j.xml.DOMConfigurator;
 import org.kauriproject.runtime.KauriRuntime;
 
+import javax.management.JMException;
+import javax.management.MBeanServer;
+import javax.management.ObjectName;
 import java.io.File;
 import java.io.IOException;
+import java.lang.management.ManagementFactory;
+import java.util.Enumeration;
 
 public class Logging {
@@ -144 +151 @@
         }
     }
+
+    /**
+     * This method was copied from Apache ZooKeeper, but it is a pretty common snippet
+     * that can be found in many places.
+     *
+     * Register the log4j JMX mbeans. Set environment variable
+     * "kauri.jmx.log4j.disable" to true to disable registration.
+     * http://logging.apache.org/log4j/1.2/apidocs/index.html?org/apache/log4j/jmx/package-summary.html
+     * @throws javax.management.JMException if registration fails
+     */
+    public static void registerLog4jMBeans() throws JMException {
+        if (Boolean.getBoolean("kauri.jmx.log4j.disable")) {
+            return;
+        }
+
+        MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
+
+        // Create and Register the top level Log4J MBean
+        HierarchyDynamicMBean hdm = new HierarchyDynamicMBean();
+
+        ObjectName mbo = new ObjectName("log4j:hierarchy=default");
+        mbs.registerMBean(hdm, mbo);
+
+        // Add the root logger to the Hierarchy MBean
+        Logger rootLogger = Logger.getRootLogger();
+        hdm.addLoggerMBean(rootLogger.getName());
+
+        // Get each logger from the Log4J Repository and add it to
+        // the Hierarchy MBean created above.
+        LoggerRepository r = LogManager.getLoggerRepository();
+        Enumeration enumer = r.getCurrentLoggers();
+        Logger logger;
+
+        while (enumer.hasMoreElements()) {
+            logger = (Logger) enumer.nextElement();
+            hdm.addLoggerMBean(logger.getName());
+        }
+    }
 }

trunk/pom.xml

@@ -600 +600 @@
         <groupId>log4j</groupId>
         <artifactId>log4j</artifactId>
-        <version>1.2.14</version>
+        <version>1.2.16</version>
       </dependency>
       <dependency>