Changeset 1434

Timestamp:

2010-02-09 16:08:49 (2 years ago)

Author:

freya

Message:

fix memory leak in options: attach event handlers to a jquery-wrapped object instead of empty <div> that is nowhere attached in the DOM tree

File:

• trunk/modules/kauri-forms/kauri-forms-framework/src/main/kauri/static-{build}.key/kauri.forms/field.js (modified) (2 diffs)

trunk/modules/kauri-forms/kauri-forms-framework/src/main/kauri/static-{build}.key/kauri.forms/field.js

@@ -165 +165 @@
     Options.prototype.$ = undefined;
     
-    /**
-    * Lazy creation of the events handling element
-    * @return An html element (jQuery)
-    * @type jQuery
-    */
-    Options.prototype.enableEvents = function() {
-
-        if (!this.$) {
-            this.$ = $("<div></div>").hide();
-        }
-        return this.$;
-    }
+
     /** 
     * Implemented "update" event
@@ -186 +175 @@
         if (!this.updateable()) return;
         
-        var $ee = this.enableEvents();
-        return (fn) ? $ee.bind("update", {options :this.values}, fn) : $ee.trigger("update");
+        return (fn) ? $(this).bind("update", {options :this.values}, fn) : $(this).trigger("update");
     }