Modify

Ticket #461 (closed Improvement)

Opened 22 months ago

Last modified 22 months ago

daisy-repository-server.bat unrecognized options

Reported by: Vitaly.Sazanovich@… Owned by: somebody
Priority: Minor Milestone:
Component: Repository Version: 2.0.1
Keywords: Cc:

Description

[jira2trac import : issue created on May 4, 2007 6:16:24 AM CEST http://issues.cocoondev.org/browse/DSY-461 ]

When trying to start daisy-repository-server.bat I received Unrecognized options error messages from JVM.
Then I echoed:
D:\dist\daisy-2.0.1\repository-server\bin>daisy-repository-server D:\dist\daisy-2.0.1\daisydata\
D:\dist\daisy-2.0.1\repository-server\merlin
*
"C:\jdk6\bin\java" "-Djava.security.policy=D:\dist\daisy-2.0.1\repository-server\merlin\bin\security.policy" -Xmx128m -Dmerlin.deployment.timeout=0 "-Dmerlin.logging.config=D:\dist\daisy-2.0.1\daisydata\
\logkit.xml" "-Ddaisy.datadir=D:\dist\daisy-2.0.1\daisydata\" "-Ddaisy.home=D:\dist\daisy-2.0.1" -Dfile.encoding=UTF-8 -Dorg.apache.commons.logging.Log=org.outerj.daisy.logging.DaisyLog? "-Djava.security.
login.config=D:\dist\daisy-2.0.1\daisydata
conf\login.config" -Duser.language=en -Duser.country=US -Duser.variant= -jar "D:\dist\daisy-2.0.1\repository-server\merlin\system\merlin\jars\merlin-cli-3.3.0.
offline -home D:\dist\daisy-2.0.1\daisydata\ -repository D:\dist\daisy-2.0.1\lib -config "D:\dist\daisy-2.0.1\daisydata
conf\myconfig.xml D:\dist\daisy-2.0.1\repository-server\conf\block.xml"
*
Unrecognized option: -offline
Could not create the Java virtual machine.

I had to remove quotes (which were introduced to fix space problem I guess) and hard-code my java call. So finally the part of merlin.bat that works is:

echo "%JAVA%" "%MERLIN_SECURITY_POLICY%" %MERLIN_JVM_OPTS% %MERLIN_CMD_LINE_ARGS% -jar %MERLIN_BOOTSTRAP_JAR%
rem "%JAVA%" "%MERLIN_SECURITY_POLICY%" %MERLIN_JVM_OPTS% %MERLIN_CMD_LINE_ARGS% -jar %MERLIN_BOOTSTRAP_JAR%
C:\jdk6\bin\java -Djava.security.policy=D:\dist\daisy-2.0.1\repository-server\merlin\bin\security.policy -Xmx128m -Dmerlin.deployment.timeout=0 -Dmerlin.logging.config=D:\dist\daisy-2.0.1\daisydata
conf\logkit.xml -Ddaisy.datadir=D:\dist\daisy-2.0.1\daisydata\ -Ddaisy.home=D:\dist\daisy-2.0.1 -Dfile.encoding=UTF-8 -Dorg.apache.commons.logging.Log=org.outerj.daisy.logging.DaisyLog? -Djava.security.auth.login.config=D:\dist\daisy-2.0.1\daisydata
conf\login.config -Duser.language=en -Duser.country=US -Duser.variant= -jar D:\dist\daisy-2.0.1\repository-server\merlin\system\merlin\jars\merlin-cli-3.3.0.jar -offline -home D:\dist\daisy-2.0.1\daisydata\ -repository D:\dist\daisy-2.0.1\lib -config D:\dist\daisy-2.0.1\daisydata
conf\myconfig.xml D:\dist\daisy-2.0.1\repository-server\conf\block.xml

Attachments

10649_end_backslash.diff (3.0 KB) - added by paul 22 months ago.
end_backslash.diff

Change History

Changed 22 months ago by paul

end_backslash.diff

comment:1 Changed 22 months ago by paul

  • Status changed from new to closed

[jira2trac import : comment created by deining on May 4, 2007 6:30:28 AM CEST]

I think the error is (more or less) on your side:
Inside your call you have the following:

"-Ddaisy.datadir=D:\dist\daisy-2.0.1\daisydata\"

However the daisy datadir should *not* end on a backslash, because the backslash on the escapes the double quote, thus resulting in the problem you are experiencing.

Maybe we should mention that "no ending backslash"-requirement on the documentation not only for the DAISY_HOME variable, but explicitely also for the paths to the data directories.

comment:2 Changed 22 months ago by paul

[jira2trac import : comment created by bruno on May 4, 2007 8:36:10 AM CEST]

yep, seems like the only thing we can do is improve the docs, I would appreciate any help in that.

comment:3 Changed 22 months ago by paul

[jira2trac import : comment created by deining on May 5, 2007 10:08:05 AM CEST]

I gave that a second thought and eventually found a really easy solution for that. With the attached fix applied, all batch scripts will work no matter whether the path given for DAISY_HOME does or does not end with a backslash. The same is true for the arguments given to all the batch files used during the daisy installation.

comment:4 Changed 22 months ago by paul

[jira2trac import : comment created by bruno on May 5, 2007 12:36:44 PM CEST]

nice fix!

applied in SVN rev 4025, removed the comment from the installation doc too.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.